EventQA dependency #437
Open
EventQA dependency #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before submitting PR#315 some code cleanup was performed (see note below). The fast jet directory was moved from StarGenerator/FastJetFilt to StarGenerator/FILT/FastJetFilt, to conform with the standard source tree layout for filters. 4f27034 625bbdd Conscript-standard directory rules allow one to specify include paths based on the module (StarGenerator) and package. The package is one directory beneath the module... before code cleanup this was the FastJetFilter directory. After cleanup, we have to apply the fast jet include path to all filters in the StarGenerator/FILT directory. ---- Note on the pp 200 HF filtered jet production. The production commenced with fast jet filter code built before code cleanup, based on the original location of the fast jet filter in the source tree.
demonstrate: root [0] .L bfc.C root [1] bfc(-1,"EventQA nodefault")
plexoos
approved these changes
Nov 11, 2022
|
Thanks for pointing this out, @klendathu2k . I know from where this dependency comes. Please allow me the opportunity to resolve this dependency by removing it rather than supporting it by modifying BFC. |
|
Of course. Better to remove a dependency that isn't needed than to
support it.
…On 2022-11-12 00:33, Gene Van Buren wrote:
Thanks for pointing this out, @klendathu2k [1] . I know from where
this dependency comes. Please allow me the opportunity to resolve this
dependency by removing it rather than supporting it by modifying BFC.
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
***@***.***>
Links:
------
[1] https://github.com/klendathu2k
[2]
#437 (comment)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVA4ILABGETG3GWATFLWH4T4LANCNFSM6AAAAAAR47WRKQ
|
|
Hi Gene, do you have other findings? Shall we proceed with this PR or go with another approach? Thanks |
|
Hi, Xin
Is there a rush? I informed the people who are responsible for this dependency, but I haven't told them it is urgent, and I'd actually prefer to close this PR unmerged and wait for the proper solution to play out over the next several weeks (months).
Thanks,
-Gene
… On Nov 23, 2022, at 1:38 PM, Xin Dong ***@***.***> wrote:
Hi Gene, do you have other findings? Shall we proceed with this PR or go with another approach? Thanks
|
|
Gene, there is no rush. It is glad to hear that you are on top of this. We can follow on this later certainly. |
|
Just a heartbeat note here (don't close this) ... this is still on me to follow up. |
akioogawa
pushed a commit
that referenced
this pull request
Apr 12, 2024
|
I believe this PR is resolved now. @klendathu2k , would you be OK with closing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a MuDST dependency in the St_QA_Maker library that is not explicitly declared in the EventQA option. Propose to make the dependence explicit.
To demonstrate: